Repository navigation
test: keep integration test output pristine - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every integration run printed the KMS's key-permission and fresh-state warnings, its routine
INFO lines and the stop-height errors two tests provoke on purpose. A run now prints only test
results: no test KMS's log reaches the terminal, and anything a healthy test KMS logs fails the
test:
state file seeded the way the KMS would create it. Neither warning fires.
anything.
stop-height error. They used a bare
#[should_panic], which any panic satisfied.fails it within two 10s waits. Either way the test prints the KMS's log instead of hanging.
file. The warnings themselves are unchanged.
Changes
3e68d50ce69f99max_height; the UNIX test config getsreconnect = false, as the TCP one has, so the KMS exits after refusing —53a874fe6ca34a6ef2f0bdf120f7d4d4d71844dfde4cf858c,2dc784bTesting
cargo test --all-features -- --test-threads 1prints nothing but results on stable and on1.85: 68 unit + 28 integration tests pass (10 ignored, all hardware-dependent). 20 serial and
5 parallel integration runs had no failures and no other output.
max_height, exits 0 after refusing, or logs a different error;warn!on every sign request, or no warn-level filter;10s waits for a stall);